Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: remove redundant code #1152

Merged
merged 4 commits into from
Aug 19, 2019
Merged

Conversation

colin4124
Copy link
Contributor

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

@colin4124 colin4124 requested a review from a team as a code owner August 12, 2019 15:50
@ghost
Copy link

ghost commented Aug 12, 2019

Can one of the admins verify this patch?

@ucbjrl
Copy link
Contributor

ucbjrl commented Aug 12, 2019

ok to test

Copy link
Contributor

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mostly looks fine, one change requested

chiselFrontend/src/main/scala/chisel3/Data.scala Outdated Show resolved Hide resolved
@seldridge seldridge merged commit eccacc3 into chipsalliance:master Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants