Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove over design #1237

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Remove over design #1237

merged 3 commits into from
Jan 7, 2020

Conversation

colin4124
Copy link
Contributor

Type of change: bug report

Impact: no functional changemodification

Development Phase: implementation

Release Notes

rename is private, and it only is called when names contains new name string in method def name . Thus no need to use getOrElse

if (this contains sanitized) {
      name(rename(sanitized))
}

@colin4124 colin4124 requested a review from a team as a code owner November 10, 2019 10:29
@ghost
Copy link

ghost commented Nov 10, 2019

Can one of the admins verify this patch?

@ucbjrl
Copy link
Contributor

ucbjrl commented Nov 10, 2019

ok to test

@edwardcwang
Copy link
Contributor

Is there some performance benefit to doing this?

@colin4124
Copy link
Contributor Author

@edwardcwang Maybe no

@chick chick added this to the 3.3.0 milestone Dec 9, 2019
ucbjrl
ucbjrl approved these changes Dec 9, 2019
View reviewed changes
Copy link
Contributor

@ucbjrl ucbjrl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2/9/19 - chisel-dev meeting approved

@chipsalliance chipsalliance deleted a comment from claassistantio Dec 9, 2019
@albert-magyar
Copy link
Contributor

@colin4124 can you sign the Contributor License Agreement?

https://cla-assistant.io/freechipsproject/chisel3

@claassistantio
Copy link

claassistantio commented Dec 9, 2019 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

chick
chick approved these changes Jan 6, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ucbjrl ucbjrl merged commit d4300b9 into chipsalliance:master Jan 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ucbjrl ucbjrl ucbjrl approved these changes

@chick chick chick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.
6 participants
@colin4124 @ucbjrl @edwardcwang @albert-magyar @claassistantio @chick