Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed code example typo in comment #1294

Merged
merged 3 commits into from
Jan 25, 2020
Merged

Fixed code example typo in comment #1294

merged 3 commits into from
Jan 25, 2020

Conversation

colin4124
Copy link
Contributor

Type of change: bug report

Impact: no functional change

Development Phase: implementation

@colin4124 colin4124 requested a review from a team as a code owner January 4, 2020 17:29
chick
chick approved these changes Jan 4, 2020
View reviewed changes
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Correct doc is happy doc

@azidar azidar added this to the 3.2.X milestone Jan 25, 2020
@azidar azidar added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Jan 25, 2020
@mergify mergify bot merged commit f1c4395 into chipsalliance:master Jan 25, 2020
mergify bot pushed a commit that referenced this pull request Jan 25, 2020
@colin4124
Fixed code example typo in comment (#1294)
1b1cc2a 
Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f1c4395)
@mergify mergify bot mentioned this pull request Jan 25, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported label Jan 25, 2020
mergify bot added a commit that referenced this pull request Jan 25, 2020
@mergify @colin4124
Fixed code example typo in comment (#1294) (#1313)
060b421 
Co-authored-by: Jim Lawson <ucbjrl@berkeley.edu>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
(cherry picked from commit f1c4395)

Co-authored-by: Leway Colin <colin4124@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chick chick chick approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
4 participants
@colin4124 @chick @azidar @ucbjrl