Bugfix: Select.instances now works with blackboxes #1303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chick
approved these changes
Jan 17, 2020
|
@chick yeah I don't think it could possibly effect existing code, unless they were catching the exception, which I think would be fine to break. |
azidar
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Jan 17, 2020
(cherry picked from commit 0a98a82)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
Previously,
Select.instanceswould fail on a cast error if called on a module that was a black box. Now, it just returnsNil, because a black box by default has no instances. This enables other functions to rely on more consistent behavior, such asSelect.collectDeep.