Printf: Add support for tabs, and give helpful error messages #1323
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
jackkoenig
requested changes
Feb 7, 2020
jackkoenig
reviewed
Feb 7, 2020
Co-Authored-By: Jack Koenig <jack.koenig3@gmail.com>
|
Oh I didn't realize this was against |
jackkoenig
pushed a commit
that referenced
this pull request
Feb 8, 2020
This was referenced Feb 8, 2020
|
oh, are the tests passing now? cuz it failed before... |
|
Yeah, you fixed the failing test |
jackkoenig
pushed a commit
that referenced
this pull request
Feb 28, 2023
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
#1321
I added support for \t in printf. I also made the
requirestatements give more information if you do something wrong which is how I figured out the tab was the problem.Type of change: bug report
Impact: API modification
Development Phase: implementation
Release Notes
Printables printf now supports \t characters.