Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dont wrap elaboration annotations (bp #1374) #1378

Merged
merged 6 commits into from
Mar 19, 2020
Merged

Dont wrap elaboration annotations (bp #1374) #1378

merged 6 commits into from
Mar 19, 2020

Commits on Mar 19, 2020

  1. Wrap elaboration in ChiselException 

    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>

squash! Wrap elaboration in ChiselException

(cherry picked from commit d67c410)
    @seldridge
    seldridge authored and mergify-bot committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    a92c2b6 View commit details
    Browse the repository at this point in the history

  2. Report trimmed stack trace of Builder cause 

    Changes the behavior of ChiselException stack trace trimming to use
either the first exception that includes a method from the Builder or
the outer exception.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 7397472)
    @seldridge
    seldridge authored and mergify-bot committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    9b317b4 View commit details
    Browse the repository at this point in the history

  3. Test nested ChiselException in ChiselMain 

    Adds two tests:

  1. Test that an internal requirement failure (a bare exception) inside
     a Builder is properly reported/trimmed by ChsielStage/ChiselMain
  2. Test that the full stack trace includes the ChiselException

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 18520bf)
    @seldridge
    seldridge committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    1dd5648 View commit details
    Browse the repository at this point in the history

  4. Code style improvement 

    Co-authored-by: Jack Koenig <koenig@sifive.com>
Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 30a0a5f)
    @seldridge
    seldridge committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    28c60c7 View commit details
    Browse the repository at this point in the history

  5. Safer generation of ChiselException.builderName 

    Change ChiselException.builderName to compute the name of Chisel's
internal Builder as opposed to hard-coding this with a string.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 969a56d)
    @seldridge
    seldridge committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    17b0f25 View commit details
    Browse the repository at this point in the history

  6. Add Scaladoc to ChiselException 

    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
(cherry picked from commit 3171cdf)
    @seldridge
    seldridge committed Mar 19, 2020
    Configuration menu
    Copy the full SHA
    c183fb4 View commit details
    Browse the repository at this point in the history