Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publishSettings to subprojects. #1390

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Mar 27, 2020

NOTE: The equivalent of this PR has been incorporated in 3.3-release (in order to publish the release).

Type of change: bug report

Impact: no functional change

Development Phase: implementation

@ucbjrl ucbjrl requested a review from jackkoenig March 27, 2020 22:32
@ucbjrl ucbjrl requested a review from a team as a code owner March 27, 2020 22:32
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ucbjrl ucbjrl added this to the 3.3.0 milestone Mar 28, 2020
@ucbjrl ucbjrl added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Mar 28, 2020
@mergify mergify bot merged commit 8903cb1 into master Mar 28, 2020
@ucbjrl ucbjrl deleted the add_publish_options_to_subprojects branch April 10, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants