expose typeEquivalent #1402
Merged
expose typeEquivalent #1402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Maybe add a unit test and scaladoc if this method is going to be exposed publicly? |
edwardcwang
reviewed
Apr 9, 2020
edwardcwang
reviewed
Apr 10, 2020
Co-Authored-By: edwardcwang <edwardcwang@users.noreply.github.com>
Co-Authored-By: edwardcwang <edwardcwang@users.noreply.github.com>
edwardcwang
added
the
Squash and merge
|
@ducky64 If you have no further objections, I'd like to get this merged. |
ducky64
approved these changes
Apr 10, 2020
There was a problem hiding this comment.
lgtm - this looks good, thanks for writing up the scaladoc!
In the future, we might want to more thoroughly test this and its edge cases (particularly with unknown-width types), but it's experimental, and I'm not completely sure we've thought that much about these semantics (like how we haven't completely resolved connect semantics yet).
|
🎉🦆 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: other enhancement
Impact: API addition (no impact on existing code)
Development Phase: proposal
Release Notes
This PR expose typeEquivalent method to DataMirror for compile time reflection to Data Type, it can help chiseltester with more strict
peek/pokeconstraint.