make parameters for util modules public

[albertchen-sifive]

Related issue:
chipsalliance/rocket-chip#2452 (comment) The parameters of modules like Queue are useful for generating better names, but it is not possible to generate a fully unique name because parameters like pipe and flow are private.

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

make parameters of modules in chisel3.util public

[CLAassistant]

All committers have signed the CLA.

[seldridge]

Would it make sense to override the desired name in these modules directly based on these parameters?

[jackkoenig]

Would it make sense to override the desired name in these modules directly based on these parameters?

That's been my thinking. It also suggests we should provide some standard, structural serialization of arbitrary Data types (not hardware values). A "prettyPrinting" would be nice, and would work fine for small things, eg. UInt(8.W) -> U8, but for deep Bundles wouldn't be ideal (it could get very long, very fast and so eventually you'd need to hash it). You could allow Bundles to override it in a way similar to overriding desiredName in modules, but then there's risk users could cause collisions. Perhaps worth it to get a name like TLBundle_paramA_paramB_paramC instead of 7fc4e38

[seldridge]

Discussed at the dev meeting. This looks good. Can you also make the gen parameter public? That may be useful in generating the name via serialization of the data type.

If you have good Chisel utility names, can you upstream those in a follow-up PR?

[mwachs5]

Suggesting changes for @seldridge 's reqest to make the gen also val

Dismissing my review to wait on @mwachs5 changes.

[seldridge]

lgtm!