Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move LFSR16 to Compatibility Mode (Deprecated in 3.2) #1476

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

seldridge
Copy link
Member

@seldridge seldridge commented Jun 16, 2020

Moves the 3.2-deprecated LFSR16 utility from chisel3.util to Chisel._. This utility was was deprecated in 3.2 in favor of chisel3.util.random.FibonacciLFSR.

In effect this does two things:

  1. Removes the LFSR16 utility from chisel3
  2. No change to Chisel._

Utilities used by the util.random tests which lived in the LFSR16 tests are moved from the latter package to the former.

Related issue: None.

Type of change: other enhancement

Impact: API modification

Development Phase: implementation

Release Notes

  • Remove deprecated LFSR16 utility

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
@seldridge seldridge changed the title Remove LFSR16 (Deprecated in 3.2) Move LFSR16 to Compatibility Mode (Deprecated in 3.2) Jun 16, 2020
@seldridge seldridge added this to the 3.4.0 milestone Jun 16, 2020
Copy link
Contributor

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine to me. Do you know of large codebases that use LFSR16?

@seldridge
Copy link
Member Author

seldridge commented Jun 17, 2020

The only codebase I'm aware of that used to use it is Rocket Chip and they switched a while back: chipsalliance/rocket-chip#2355

@seldridge seldridge merged commit 3a276c8 into master Jun 17, 2020
@seldridge seldridge deleted the remove-LFSR16 branch June 17, 2020 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants