Memoize the hashcode of the ChiselCircuitAnnotation #1485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
approved these changes
Jun 19, 2020
jackkoenig
added
the
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Jun 19, 2020
(cherry picked from commit 9bda7a7)
mergify bot
pushed a commit
that referenced
this pull request
Jun 19, 2020
(cherry picked from commit 9bda7a7)
14 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We hash all of the annotations between phases so this makes that much faster after Chisel elaboration. @seldridge discussed changing the hashcode to be either a constant or just hash the name of the top-module or something so that we don't even both hashing the circuit, but I'll leave that for a later change. I would really like this in 3.3.2 because it's costing a lot of runtime.
Related issue:
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Memoize hashcode of ChiselCircuitAnnotation, improves performance of multi-phase generators