Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: simplify sbt snippet and update to the latest stable release #1686

Merged
merged 1 commit into from
Dec 2, 2020
Merged

readme: simplify sbt snippet and update to the latest stable release #1686

merged 1 commit into from
Dec 2, 2020

Conversation

ekiwi
Copy link
Contributor

@ekiwi ekiwi commented Dec 1, 2020

Contributor Checklist

  • Did you specify the type of improvement?

Type of Improvement

  • documentation improvement

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@CLAassistant
Copy link

CLAassistant commented Dec 1, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@jackkoenig jackkoenig added this to the 3.4.x milestone Dec 1, 2020
jackkoenig
jackkoenig approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Backporting to 3.4.x because that's what's used on the website (and this README is still the landing page)

@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Dec 1, 2020
@ekiwi
Copy link
Contributor Author

ekiwi commented Dec 1, 2020

LGTM, thanks!

did you double check that I did not break anything?

Also, is it ok, that I made "chiseltest" a test dependency only?

@mergify mergify bot merged commit ba05dca into chipsalliance:master Dec 2, 2020
mergify bot pushed a commit that referenced this pull request Dec 2, 2020
@ekiwi
readme: simplify sbt snippet and update to the latest stable release (#…
084dc45 
…1686)

(cherry picked from commit ba05dca)
@mergify mergify bot mentioned this pull request Dec 2, 2020
Merged
@mergify mergify bot added the Backported This PR has been backported label Dec 2, 2020
@jackkoenig
Copy link
Contributor

did you double check that I did not break anything?

Not originally, but just did and it works. These instructions are too minimal IMO, but your change was just updating the versions and artifacts which you did correctly 🙂

Also, is it ok, that I made "chiseltest" a test dependency only?

Not only is it "okay", I think it is better and should be what we encourage.

@ekiwi
Copy link
Contributor Author

ekiwi commented Dec 2, 2020

These instructions are too minimal IMO

Also somewhat passive aggressive:

If you insist on setting up your own project

mergify bot added a commit that referenced this pull request Dec 2, 2020
@mergify @ekiwi
readme: simplify sbt snippet and update to the latest stable release (#…
64a7d6c 
…1686) (#1687)

(cherry picked from commit ba05dca)

Co-authored-by: Kevin Laeufer <electron.kiwi@gmail.com>
@jackkoenig
Copy link
Contributor

Yeah, we really need to just improve chisel-template, make it a proper Github template and also post tarballs and maybe fat tarballs (that include all dependencies).

@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@albertchen-sifive
delete usages of toSet for determinism (#1686)
b750754 
* delete usages of toSet for determinism

* add formatting suggestion from code review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
3 participants
@ekiwi @CLAassistant @jackkoenig