Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect usage of emitFirrtl in test #1817

Merged
merged 1 commit into from
Mar 17, 2021
Merged

Fix incorrect usage of emitFirrtl in test #1817

merged 1 commit into from
Mar 17, 2021

Conversation

seldridge
Copy link
Member

Change a test to use emitChirrtl instead of emitFirrtl. This test
isn't supposed to be running the Scala FIRRTL Compiler, but the latter
method causes this to happen.

This fixes a mistake I introduced in b0389cc.

Contributor Checklist

  • [n/a] Did you add Scaladoc to every public function/method?
  • [n/a] Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • code cleanup

API Impact

None.

Backend Code Generation Impact

None.

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference.

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.0, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@seldridge
Fix incorrect usage of emitFirrtl in test
9a29805 
Change a test to use emitChirrtl instead of emitFirrtl. This test
isn't supposed to be running the Scala FIRRTL Compiler, but the latter
method causes this to happen.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@seldridge seldridge added this to the 3.4.x milestone Mar 17, 2021
@jackkoenig jackkoenig added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label Mar 17, 2021
@mergify mergify bot merged commit 492a71d into master Mar 17, 2021
mergify bot pushed a commit that referenced this pull request Mar 17, 2021
@seldridge
Fix incorrect usage of emitFirrtl in test (#1817)
0b190ce 
Change a test to use emitChirrtl instead of emitFirrtl. This test
isn't supposed to be running the Scala FIRRTL Compiler, but the latter
method causes this to happen.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 492a71d)
@mergify mergify bot mentioned this pull request Mar 17, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Mar 17, 2021
mergify bot added a commit that referenced this pull request Mar 17, 2021
@mergify @seldridge
Fix incorrect usage of emitFirrtl in test (#1817) (#1818)
3f987c9 
Change a test to use emitChirrtl instead of emitFirrtl. This test
isn't supposed to be running the Scala FIRRTL Compiler, but the latter
method causes this to happen.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit 492a71d)

Co-authored-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
@jackkoenig jackkoenig deleted the dev/seldridge/fixup branch July 7, 2021 03:44
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
jackkoenig pushed a commit that referenced this pull request Feb 28, 2023
@albertchen-sifive
Inline Boolean Expressions (#1817)
40cb49f 
The following conditions must be satisfied to inline:

1. has type Utils.BoolType
2. is bound to a DefNode with name starting with '_'
3. is bound to a DefNode with a source locator that
   points at the same file and line number. If it is a MultiInfo source
   locator, the set of file and line number pairs must be the same. Source
   locators may point to different column numbers.
4. InlineBooleanExpressionsMax has not been exceeded
5. is not a Mux

Also updates the Verilog emitter to break up lines greater than 120 characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkoenig jackkoenig jackkoenig approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@seldridge @jackkoenig