Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PLA #1912

Merged
merged 4 commits into from
May 20, 2021
Merged

Implement PLA #1912

merged 4 commits into from
May 20, 2021

Conversation

sequencer
Copy link
Member

This PR implements PLA, authored by @yqszxx

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

This was referenced May 12, 2021
Closed
Closed
@sequencer sequencer added this to the 3.2.x milestone May 20, 2021
seldridge
seldridge approved these changes May 20, 2021
View reviewed changes
Copy link
Member

@seldridge seldridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition to the standard library. Consider dropping this directly into chisel3.util and skipping experimental.

I didn't go over the and/or logic in much detail, but the tests look good.

Nitty comments throughout.

src/main/scala/chisel3/util/experimental/pla.scala Outdated Show resolved Hide resolved
src/main/scala/chisel3/util/experimental/pla.scala Outdated Show resolved Hide resolved
src/main/scala/chisel3/util/experimental/pla.scala Outdated Show resolved Hide resolved
src/main/scala/chisel3/util/experimental/pla.scala Outdated Show resolved Hide resolved
@sequencer sequencer added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label May 20, 2021
@mergify mergify bot merged commit 1c1a4d7 into master May 20, 2021
mergify bot pushed a commit that referenced this pull request May 20, 2021
@sequencer
Implement PLA (#1912)
39359e3 
* implement pla

* implement test for pla

* implement inverter matrix of PLA generator

* fix for review.

Co-authored-by: Boyang Han <yqszxx@gmail.com>
(cherry picked from commit 1c1a4d7)
@mergify mergify bot mentioned this pull request May 20, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 20, 2021
@sequencer
Implement PLA (#1912)
06169e6 
* implement pla

* implement test for pla

* implement inverter matrix of PLA generator

* fix for review.

Co-authored-by: Boyang Han <yqszxx@gmail.com>
(cherry picked from commit 1c1a4d7)
@mergify mergify bot mentioned this pull request May 20, 2021
Merged
mergify bot pushed a commit that referenced this pull request May 20, 2021
@sequencer
Implement PLA (#1912)
8a90424 
* implement pla

* implement test for pla

* implement inverter matrix of PLA generator

* fix for review.

Co-authored-by: Boyang Han <yqszxx@gmail.com>
(cherry picked from commit 1c1a4d7)
@mergify mergify bot mentioned this pull request May 20, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label May 20, 2021
mergify bot added a commit that referenced this pull request May 20, 2021
@mergify @sequencer
Implement PLA (backport #1912) (#1926)
246de4c 
* Implement PLA (#1912)

* implement pla

* implement test for pla

* implement inverter matrix of PLA generator

* fix for review.

Co-authored-by: Boyang Han <yqszxx@gmail.com>
(cherry picked from commit 1c1a4d7)

* fix 2.11

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
mergify bot added a commit that referenced this pull request May 20, 2021
@mergify @sequencer
Implement PLA (backport #1912) (#1927)
2f938c7 
* Implement PLA (#1912)

* implement pla

* implement test for pla

* implement inverter matrix of PLA generator

* fix for review.

Co-authored-by: Boyang Han <yqszxx@gmail.com>
(cherry picked from commit 1c1a4d7)

* fix 2.11

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
mergify bot added a commit that referenced this pull request May 20, 2021
@mergify @sequencer
Implement PLA (backport #1912) (#1928)
bc54efb 
* Implement PLA (#1912)

* implement pla

* implement test for pla

* implement inverter matrix of PLA generator

* fix for review.

Co-authored-by: Boyang Han <yqszxx@gmail.com>
(cherry picked from commit 1c1a4d7)

* fix 2.11

Co-authored-by: Jiuyang Liu <liu@jiuyang.me>
sequencer added a commit that referenced this pull request May 25, 2021
@sequencer
Revert "Implement PLA (backport #1912) (#1927)"
4b0558d 
This reverts commit 2f938c7.
sequencer added a commit that referenced this pull request May 25, 2021
@sequencer
Revert "Implement PLA (backport #1912) (#1926)"
4724ed4 
This reverts commit 246de4c.
jackkoenig pushed a commit that referenced this pull request May 25, 2021
@sequencer
Revert "Implement PLA (backport #1912) (#1926)" (#1935)
cd4fc95 
This reverts commit 246de4c.
jackkoenig pushed a commit that referenced this pull request May 25, 2021
@sequencer
Revert "Implement PLA (backport #1912) (#1927)" (#1936)
9077fab 
This reverts commit 2f938c7.
@jackkoenig jackkoenig deleted the pla branch July 7, 2021 03:43
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yqszxx yqszxx yqszxx left review comments

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
3.2.x
Development

Successfully merging this pull request may close these issues.
3 participants
@sequencer @seldridge @yqszxx