Espresso Decoder #1964
Merged
Espresso Decoder #1964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sequencer
commented
Jun 16, 2021
sequencer
force-pushed
the
decoder
branch
4 times, most recently
from
43c26a8
to
2aed3db
Compare
|
Can you rebase once #2003 is merged? |
|
OK I'll rebase this. |
jackkoenig
reviewed
Jul 12, 2021
sequencer
force-pushed
the
decoder
branch
2 times, most recently
from
e15afc2
to
eb7433e
Compare
|
@jackkoenig done:) |
jackkoenig
reviewed
Jul 12, 2021
src/main/scala/chisel3/util/experimental/decode/EspressoMinimizer.scala
Outdated
Show resolved
Hide resolved
jackkoenig
reviewed
Jul 13, 2021
Comment on lines
66
to
73
| case EspressoNotFoundException => | ||
| logger.error( | ||
| """espresso is not found in your PATH, fall back to QMC. | ||
| |Quine-McCluskey is a NP complete algorithm, may run forever or run out of memory in large decode tables. | ||
| |To get rid of this warning, please use `decoder.qmc` directly, or add espresso to your PATH. | ||
| |""".stripMargin | ||
| ) | ||
| qmc(input, truthTable) |
There was a problem hiding this comment.
I sort of screwed up in my previous comments--since this is the generic API and we can always fall back to QMC, we should just catch all IOExceptions, but we should forward some of the error message instead of always suppressing and saying "espresso not found".
I think having the EspressoNotFoundException is good, but we also need to catch other java.io.Exceptions, and report a similar error message but perhaps include some information from the Exception in the logged message.
There was a problem hiding this comment.
4ecd25f should have implemented this.
|
@jackkoenig ask for taking a look again ;p |
jackkoenig
approved these changes
Jul 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. Implement espresso wrapper.2. upstream espresso.3. add espresso CI. #20034. merge this PR
Contributor Checklist
docs/src?Type of Improvement
API Impact
Backend Code Generation Impact
Espresso generated PLA maybe different from QMC generated, for legacy QMC users, including SiFive and RocketChip users.
Decode circuit maybe different, but formally equivalent.
Desired Merge Strategy
Release Notes
Add Espresso Decoder
Reviewer Checklist (only modified by reviewer)
Please Merge?