Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ChiselEnum docs #2016

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Fix ChiselEnum docs #2016

merged 1 commit into from
Jul 7, 2021

Conversation

jackkoenig
Copy link
Contributor

@jackkoenig jackkoenig commented Jul 7, 2021 •
edited
Loading

Also add newline to end of verilog modifier code blocks so that there
is always a newline between code blocks and following material.

Contributor Checklist

  • [NA] Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • [NA] Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • documentation

API Impact

No impact

Backend Code Generation Impact

No impact

Desired Merge Strategy

  • Squash

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (3.2.x, 3.3.x, 3.4.x, 3.5.0) ?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

@jackkoenig
Fix ChiselEnum docs
3598d98 
Also add newline to end of `verilog` modifier code blocks so that there
is always a newline between code blocks and following material.
@jackkoenig jackkoenig added this to the 3.4.x milestone Jul 7, 2021
@jackkoenig jackkoenig added Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. and removed Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. labels Jul 7, 2021
@jackkoenig jackkoenig merged commit 558df41 into master Jul 7, 2021
mergify bot pushed a commit that referenced this pull request Jul 7, 2021
@jackkoenig
Fix ChiselEnum docs (#2016)
2190ef2 
Also add newline to end of `verilog` modifier code blocks so that there
is always a newline between code blocks and following material.

(cherry picked from commit 558df41)
@mergify mergify bot mentioned this pull request Jul 7, 2021
Merged
@mergify mergify bot added the Backported This PR has been backported label Jul 7, 2021
mergify bot added a commit that referenced this pull request Jul 8, 2021
@mergify @jackkoenig
Fix ChiselEnum docs (#2016) (#2017)
d9009d5 
Also add newline to end of `verilog` modifier code blocks so that there
is always a newline between code blocks and following material.

(cherry picked from commit 558df41)

Co-authored-by: Jack Koenig <koenig@sifive.com>
@jackkoenig jackkoenig deleted the fix-chisel-enum-docs branch July 13, 2021 00:13
@MAFOR-TECH MAFOR-TECH mentioned this pull request Oct 24, 2021
Closed
@sequencer sequencer mentioned this pull request Nov 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seldridge seldridge seldridge approved these changes

Assignees
No one assigned
Labels
Backported This PR has been backported
Projects
None yet
Milestone
3.4.x
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkoenig @seldridge