Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not silence stack traces #2370

Closed

Conversation

oharboe
Copy link
Contributor

@oharboe oharboe commented Jan 27, 2022

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you mark as Please Merge?

Copy link
Member

@sequencer sequencer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think PrintFullStackTraceAnnotation can help this.
But on the other hand, I was always having issues in chisel internal tests. I think adding PrintFullStackTraceAnnotation to chisel internal tests sounds a good idea.

@@ -14,7 +14,7 @@ lazy val commonSettings = Seq (
Resolver.sonatypeRepo("releases")
),
organization := "edu.berkeley.cs",
version := "3.5-SNAPSHOT",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think build.sbt should not be changed.

@@ -235,7 +235,6 @@ private[chisel3] class ErrorLog {

if (!allErrors.isEmpty) {
throw new ChiselException("Fatal errors during hardware elaboration. Look above for error list.")
with scala.util.control.NoStackTrace
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Chisel have PrintFullStackTraceAnnotation. User can use that to print full stacks.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried PrintFullStackTraceAnnotation, didn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've asked some questions in https://groups.google.com/g/chisel-users/c/61vkD3EfleA

Resulting in a github issue filed #501

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried: ucb-bar/chiseltest#501?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, doesnt work.

the error can probably be reproduced by

0.U(1.W)(0,1)

i will gove a go at creating a test case
...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you tried: ucb-bar/chiseltest#501?

Yes, Updated #501 with a test-case.

@oharboe oharboe closed this Feb 2, 2022
@oharboe oharboe deleted the do-not-silence-stack-traces branch February 2, 2022 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants