-
Notifications
You must be signed in to change notification settings - Fork 603
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not silence stack traces #2370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PrintFullStackTraceAnnotation
can help this.
But on the other hand, I was always having issues in chisel internal tests. I think adding PrintFullStackTraceAnnotation
to chisel internal tests sounds a good idea.
@@ -14,7 +14,7 @@ lazy val commonSettings = Seq ( | |||
Resolver.sonatypeRepo("releases") | |||
), | |||
organization := "edu.berkeley.cs", | |||
version := "3.5-SNAPSHOT", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think build.sbt should not be changed.
@@ -235,7 +235,6 @@ private[chisel3] class ErrorLog { | |||
|
|||
if (!allErrors.isEmpty) { | |||
throw new ChiselException("Fatal errors during hardware elaboration. Look above for error list.") | |||
with scala.util.control.NoStackTrace |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chisel have PrintFullStackTraceAnnotation
. User can use that to print full stacks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried PrintFullStackTraceAnnotation, didn't work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked some questions in https://groups.google.com/g/chisel-users/c/61vkD3EfleA
Resulting in a github issue filed #501
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried: ucb-bar/chiseltest#501?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, doesnt work.
the error can probably be reproduced by
0.U(1.W)(0,1)
i will gove a go at creating a test case
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tried: ucb-bar/chiseltest#501?
Yes, Updated #501 with a test-case.
Contributor Checklist
docs/src
?Type of Improvement
API Impact
Backend Code Generation Impact
Desired Merge Strategy
Release Notes
Reviewer Checklist (only modified by reviewer)
3.4.x
, [small] API extension:3.5.x
, API modification or big change:3.6.0
)?Please Merge
?