-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make firtool options for elaborateGeneratedModule
in workspace
parametric
#3952
Make firtool options for elaborateGeneratedModule
in workspace
parametric
#3952
Conversation
…h different firtool options i.e. -g (chipsalliance#3932)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for missing your issue, but this LGTM! It would be nice to expose this on EphemeralSimulator
as well, but it's a useful improvement as is!
You can run formatting on the code with |
Yes sure! I think intellij idea automatically reformatted the code with another fmt style. I will make sure to check it next time. |
Actually, I am already working on a "parametric" simulator that also makes use of custom firtool options for my project. However, it also includes some other functionalities that are specific for my project but not all of them (some are more generic like vcd/fst emission). |
Coincidentally it did a pretty good job, it just missed 1 rule/file 😂. Maybe it automatically picked up our format rules but didn't format that file? 🤷♀️
Neat! Well if there's anything that you think belongs in upstream, please feel free to open issues or PRs. |
Fixes #3932
Contributor Checklist
docs/src
?Type of Improvement
Desired Merge Strategy
Release Notes
This adds the support in
Chiselsim
to configure the workspace with additional args forfirtool
(#3932). The user can specify how the sv circuit is compiled for simulation (i.e. including debug information-g
).Reviewer Checklist (only modified by reviewer)
3.6.x
,5.x
, or6.x
depending on impact, API modification or big change:7.0
)?Enable auto-merge (squash)
, clean up the commit message, and label withPlease Merge
.Create a merge commit
.