Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move backend compilation utilities #400

Merged
merged 11 commits into from
Feb 1, 2017

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Dec 9, 2016

Move BackendCompilationUtilities into a firrtl util package.
Some of this could be moved into a more general tools package, but since chisel3 already has a dependency on firrtl ...

This should be merged after chipsalliance/firrtl#400 and along with ucb-bar/chisel-testers#72

Some of this could be moved into a more general tools package, but since chisel3 already has a dependency on firrtl ...
@jackkoenig jackkoenig added this to the 3.0.0 milestone Dec 14, 2016
Don't push this:
duplicate symbol vl_finish(char const*, int, char const*) in:
    top.o
    verilated.o
ld: 1 duplicate symbol for architecture x86_64
collect2: error: ld returned 1 exit status
@jackkoenig
Copy link
Contributor

I made a Firrtl PR (chipsalliance/firrtl#427) that fixes #452 and added a commit to this to use the new createTestDirectory so we stop dumping in /tmp/

@jackkoenig
Copy link
Contributor

@chick So this PR is partially deleting verilogToCpp from chisel3 which you modified in 632a716. The tests pass even though it's deleted, should they have passed?

@chick
Copy link
Contributor

chick commented Feb 1, 2017

@ucbjrl @jackkoenig yes, this changes will break the verilog moving annotations. The chisel3 test are obviously not robust enough. It simply checks that a verilog resource makes it into the directory. The code being lost here, looks to see if a list of verilog files file (.f) has been created and if so adds a reference to it on the verilator and vcs command line. I'll make a PR to recover this functionality in firrtl

@jackkoenig
Copy link
Contributor

Thanks @chick. I think it's time to merge this and stop dumping so much junk in /tmp/

@jackkoenig
Copy link
Contributor

1 run of sbt test in Chisel creates 64M of files

@jackkoenig jackkoenig merged commit 24ad38a into master Feb 1, 2017
@jackkoenig jackkoenig deleted the moveBackendCompilationUtilities branch February 1, 2017 18:28
@chick
Copy link
Contributor

chick commented Feb 1, 2017

@jackkoenig can you give a quick review to firrtl pr #428, to keep things moving forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants