Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

checkTypeEquivalence now considers ProbeInfo #4064

Merged
merged 9 commits into from
May 8, 2024
Merged

checkTypeEquivalence now considers ProbeInfo #4064

merged 9 commits into from
May 8, 2024

Conversation

mwachs5
Copy link
Contributor

@mwachs5 mwachs5 commented May 8, 2024 •
edited
Loading

Contributor Checklist

  • Did you add Scaladoc to every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you delete any extraneous printlns/debugging code?
  • Did you specify the type of improvement?
  • Did you add appropriate documentation in docs/src?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • API modification

Desired Merge Strategy

  • Squash: The PR will be squashed and merged (choose this if you have no preference).

Release Notes

Now checkTypeEquivalence will check whether data have the same probe type modifier including writeability and color (layer).

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels? (Select the most appropriate one based on the "Type of Improvement")
  • Did you mark the proper milestone (Bug fix: 3.6.x, 5.x, or 6.x depending on impact, API modification or big change: 7.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?
  • Did you do one of the following when ready to merge:
    • Squash: You/ the contributor Enable auto-merge (squash), clean up the commit message, and label with Please Merge.
    • Merge: Ensure that contributor has cleaned up their commit history, then merge with Create a merge commit.

@mwachs5
Copy link
Contributor Author

mwachs5 commented May 8, 2024

not sure what's going on with the docs change, will revert that.

jackkoenig
jackkoenig approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but please fix parentheses

@jackkoenig jackkoenig added this to the 7.0 milestone May 8, 2024
dtzSiFive
dtzSiFive approved these changes May 8, 2024
View reviewed changes
Copy link
Member

@dtzSiFive dtzSiFive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!

@mwachs5 mwachs5 enabled auto-merge (squash) May 8, 2024 23:24
@mwachs5 mwachs5 added the Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI. label May 8, 2024
@mwachs5 mwachs5 merged commit 62f8a05 into main May 8, 2024
14 checks passed
@mwachs5 mwachs5 deleted the probe-type-equivalence branch May 8, 2024 23:38
@jackkoenig jackkoenig modified the milestones: 7.0, 6.x May 30, 2024
@mergify mergify bot added the Backported This PR has been backported label May 30, 2024
mergify bot pushed a commit that referenced this pull request May 30, 2024
@mwachs5 @mergify
checkTypeEquivalence now considers ProbeInfo (#4064)
a822483 
* type equivalence includes probe
* Add type equivalence checks for Probes, including writeability and color.

(cherry picked from commit 62f8a05)
@mergify mergify bot mentioned this pull request May 30, 2024
Merged
14 tasks
chiselbot pushed a commit that referenced this pull request May 30, 2024
@mergify @mwachs5 @jackkoenig
checkTypeEquivalence now considers ProbeInfo (backport #4064) (#4112)
f554181 
* checkTypeEquivalence now considers ProbeInfo (#4064)

* type equivalence includes probe
* Add type equivalence checks for Probes, including writeability and color.

(cherry picked from commit 62f8a05)

* Remove notion of probe color which is a Chisel 7 feature

---------

Co-authored-by: Megan Wachs <megan@sifive.com>
Co-authored-by: Jack Koenig <koenig@sifive.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dtzSiFive dtzSiFive dtzSiFive approved these changes

@jackkoenig jackkoenig jackkoenig approved these changes

@seldridge seldridge Awaiting requested review from seldridge

Assignees
No one assigned
Labels
API Modification Backported This PR has been backported Please Merge Accepted PRs that are ready to be merged. Useful when waiting on CI.
Projects
None yet
Milestone
6.x
Development

Successfully merging this pull request may close these issues.
3 participants
@mwachs5 @jackkoenig @dtzSiFive