Deprecate all Injecting Aspect Code #4415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deprecate injecting aspect code as of Chisel 6.6.0. These were planned to be deprecated some time ago (see ROADMAP.md). However, these had a long user in @sequencer. He is now off of these and there is nothing blocking their removal. I will follow this with a commit to remove these from `main` for Chisel 7. For similar, verification-focused functionality can be selectively added to the circuit, use layers. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
mergify bot
pushed a commit
that referenced
this pull request
Sep 27, 2024
Deprecate injecting aspect code as of Chisel 6.6.0. These were planned to be deprecated some time ago (see ROADMAP.md). However, these had a long user in @sequencer. He is now off of these and there is nothing blocking their removal. I will follow this with a commit to remove these from `main` for Chisel 7. For similar, verification-focused functionality can be selectively added to the circuit, use layers. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com> (cherry picked from commit d292a5e) # Conflicts: # build.sbt
seldridge
added a commit
that referenced
this pull request
Sep 27, 2024
seldridge
pushed a commit
that referenced
this pull request
Sep 27, 2024
Deprecate injecting aspect code as of Chisel 6.6.0. These were planned to be deprecated some time ago (see ROADMAP.md). However, these had a long user in @sequencer. He is now off of these and there is nothing blocking their removal. For similar, verification-focused functionality can be selectively added to the circuit, use layers. (cherry picked from commit d292a5e) Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
debs-sifive
pushed a commit
that referenced
this pull request
Oct 15, 2024
Deprecate injecting aspect code as of Chisel 6.6.0. These were planned to be deprecated some time ago (see ROADMAP.md). However, these had a long user in @sequencer. He is now off of these and there is nothing blocking their removal. I will follow this with a commit to remove these from `main` for Chisel 7. For similar, verification-focused functionality can be selectively added to the circuit, use layers. Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate injecting aspect code as of Chisel 6.6.0. These were planned to be deprecated some time ago (see ROADMAP.md). However, these had a long user in @sequencer. He is now off of these and there is nothing blocking their removal.
I will follow this with a commit to remove these from
mainfor Chisel 7.For similar, verification-focused functionality can be selectively added to the circuit, use layers.
Release Notes
Deprecate injecting aspects as of Chisel 6.6.0 and plan for removal in Chisel 7.