Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate more Aspect parts (backport #4420) #4421

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Sep 27, 2024

Deprecate the remaining parts of Aspects that were missed in earlier commits. After this, the only non-deprecated part of the aop library are the Select utilities.

Release Notes

Deprecate everything in aop package except Select library.


This is an automatic backport of pull request #4420 done by Mergify.

@mergify mergify bot added Backport Automated backport, please consider for minor release bp-conflict labels Sep 27, 2024
Copy link
Contributor Author

mergify bot commented Sep 27, 2024

Cherry-pick of e213eda has failed:

On branch mergify/bp/6.x/pr-4420
Your branch is up to date with 'origin/6.x'.

You are currently cherry-picking commit e213edaed.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   core/src/main/scala/chisel3/aop/Aspect.scala
	modified:   src/main/scala/chisel3/aop/AspectLibrary.scala
	modified:   src/main/scala/chisel3/aop/inspecting/InspectingAspect.scala
	modified:   src/main/scala/chisel3/stage/phases/AspectPhase.scala
	modified:   src/main/scala/chisel3/stage/phases/MaybeAspectPhase.scala

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   build.sbt

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@github-actions github-actions bot added the Deprecation Deprecates an API, will be included in release notes label Sep 27, 2024
Deprecate the remaining parts of Aspects that were missed in earlier
commits.  After this, the only non-deprecated part of the `aop` library
are the `Select` utilities.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@sifive.com>
(cherry picked from commit e213eda)

# Conflicts:
#	build.sbt
@seldridge seldridge enabled auto-merge (squash) September 28, 2024 03:21
@seldridge seldridge merged commit 0167e9e into 6.x Sep 28, 2024
13 checks passed
@seldridge seldridge deleted the mergify/bp/6.x/pr-4420 branch September 28, 2024 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Automated backport, please consider for minor release bp-conflict Deprecation Deprecates an API, will be included in release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant