Update comments describing Decoupled/ReadyValid - fix #437. #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edwardcwang
reviewed
Feb 7, 2017
| * enforced via use of concrete subclasses. | ||
| * The base protocol implied by the directionality is that the producer uses | ||
| * the interface as-is (outputs bits) while the consumer | ||
| * uses the flipped interface (inputs bits). |
There was a problem hiding this comment.
Seems like the comment could be better reflowed here?
edwardcwang
approved these changes
Feb 7, 2017
jackkoenig
requested changes
Feb 22, 2017
| * These could be replaced with: | ||
| * val enq = Flipped(EnqIO(gen)) | ||
| * val deq = Flipped(DeqIO(gen)) | ||
| * once issue #492 is resolved. |
There was a problem hiding this comment.
This comment should be changed
There was a problem hiding this comment.
What should it be changed to?
jackkoenig
approved these changes
Apr 26, 2017
It seems there is a valid use case for EnqIO/DeqIO and updating the comments may clear some of the confusion and encourage their usage.
Re-flow comments for ReadyValidIO() Add gen param to DecoupledIO() and IrrevocableIO().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems there is a valid use case for EnqIO/DeqIO and updating the comments may clear some of the confusion and encourage their usage.