Make Bundle abstract #774
Merged
Make Bundle abstract #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducky64
approved these changes
Feb 9, 2018
|
Can we merge this? |
|
Yep |
ucbjrl
added a commit
to freechipsproject/chisel-testers
that referenced
this pull request
Feb 22, 2018
Now that Bundle is an abstract class (chipsalliance/chisel#774), replace a bare Bundle with a concrete one.
ucbjrl
added a commit
to freechipsproject/chisel-testers
that referenced
this pull request
Feb 22, 2018
* Fix use of bare Bundle in MemPokeSpec. Now that Bundle is an abstract class (chipsalliance/chisel#774), replace a bare Bundle with a concrete one. * Respond to comments - use minimal bare Bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure why it wasn't abstract.
The basic motivation is that autoclonetype doesn't work on instances of Bundle because it can't figure out what to do about the CompileOptions. It does however, work on
new Bundle {}because it's an anonymous subclass with no constructor arguments. I'm really not sure why the UIntOps test didn't fail in #754. We could of course special case this and make it work, but I'm honestly not sure why Bundle isn't abstract?Type of change
Impact
Development Phase
Release Notes
Make Bundle abstract