Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UIntToOH for output widths larger than 2^(input width) #823

Merged
merged 4 commits into from
May 24, 2018

Conversation

aswaterman
Copy link
Member

@aswaterman aswaterman commented May 24, 2018

UIntToOH(foo, bar) fails when bar > (2^foo.getWidth).

Related issue: #822

Type of change: bug report +/- feature request

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

Copy link
Contributor

@jackkoenig jackkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aswaterman aswaterman merged commit bffc8b9 into master May 24, 2018
@aswaterman aswaterman deleted the uinttooh-width branch May 24, 2018 18:46
@aswaterman
Copy link
Member Author

@hcook fyi

@ucbjrl ucbjrl added this to the 3.1.1 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants