Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Input() and Output() and test for same. #862

Merged
merged 1 commit into from
Jul 20, 2018

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Jul 19, 2018

Related issue: #861

Type of change: bug report

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes
Input() and Output() have been available in Chisel2 since ucb-bar/chisel2-deprecated#734. Provide support for them in the compatibility package.

@ucbjrl ucbjrl requested a review from ducky64 July 19, 2018 17:28
@edwardcwang edwardcwang self-requested a review July 19, 2018 19:25
Copy link
Contributor

@edwardcwang edwardcwang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but does it work with rocket/etc?

Copy link
Contributor

@ducky64 ducky64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@edwardcwang edwardcwang merged commit 8f96e50 into master Jul 20, 2018
@ucbjrl ucbjrl added this to the 3.1.2 milestone Jul 23, 2018
@edwardcwang edwardcwang deleted the compatibilityupdate branch July 26, 2018 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants