add HasBlackBoxPath to BlackBoxUtils.scala #903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
ok to test |
|
LGTM, should we also changed |
chick
approved these changes
Oct 17, 2018
| @deprecated("Use addResource instead", "3.2") | ||
| def setResource(blackBoxResource: String): Unit = addResource(blackBoxResource) | ||
|
|
||
| def addResource(blackBoxResource: String): Unit = { |
There was a problem hiding this comment.
I think it would be nice to add some scaladoc here, in particular, providing an example
of what a resource path looks like.
| trait HasBlackBoxPath extends BlackBox { | ||
| self: BlackBox => | ||
|
|
||
| def addPath(blackBoxPath: String): Unit = { |
There was a problem hiding this comment.
ScalaDoc here too. Probably worth mentioning that the working directory is
not likely to be the same as the target directory
…into HasBlackBoxPath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HasBlackBoxPaththat acts likeHasBlackBoxResourceexcept that it works with files outside of the resources directory.setResourcetoaddResourcebecause multiple calls will result in multiple resources being copied to the target directory.Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation
Metadata: