-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump sbt to 1.2.6; update dependencies #941
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Why the explicit reference to junit? I was running into problems with transitive dependencies, specifically: |
@ucbjrl can you add a comment about that? That is a bit weird... |
The: sbt test and sbt "++2.12.7" test both work correctly. But sbt +test and sbt "++2.11.12" test both fail with
when compiling for 2.11.12. Adding a specific dependency on junit in build.sbt seems to alleviate the issue. NOTE: mill has a similar problem, so it may be a ammonite issue. |
Would you mind adding a short explanation as a comment in the build.sbt? |
Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
Bump sbt version to 1.2.6
Update dependency versions