Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sbt to 1.2.6; update dependencies #941

Merged
merged 3 commits into from
Nov 21, 2018
Merged

Bump sbt to 1.2.6; update dependencies #941

merged 3 commits into from
Nov 21, 2018

Conversation

ucbjrl
Copy link
Contributor

@ucbjrl ucbjrl commented Nov 16, 2018

Type of change: other enhancement

Impact: no functional change

Development Phase: implementation

Release Notes
Bump sbt version to 1.2.6
Update dependency versions

@ucbjrl ucbjrl requested a review from a team as a code owner November 16, 2018 18:17
Copy link
Contributor

@chick chick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ucbjrl
Copy link
Contributor Author

ucbjrl commented Nov 16, 2018

Why the explicit reference to junit?

I was running into problems with transitive dependencies, specifically:
Symbol 'term org.junit' is missing from the classpath.
I suspect this is due to interaction between the latest version of sbt and org.scala-sbt.ivy. It may be because junit is special - it's pure Java and independent of the Scala compiler. Forcing a more recent version of junit seemed to resolve those problems.

@jackkoenig
Copy link
Contributor

@ucbjrl can you add a comment about that? That is a bit weird...

@ucbjrl
Copy link
Contributor Author

ucbjrl commented Nov 16, 2018

The:
Symbol 'term org.junit' is missing from the classpath
occurred when running tests under Scala 2.11.12.

sbt test

and

sbt "++2.12.7" test

both work correctly. But

sbt +test

and

sbt "++2.11.12" test

both fail with

[error] /nscratch/ucbjrl/firrtl/src/test/scala/firrtlTests/FirrtlSpec.scala:193:18: Symbol 'term org.junit' is missing from the classpath.
[error] This symbol is required by 'class org.scalatest.junit.JUnitRunner'.
[error] Make sure that term junit is in your classpath and check for conflicting dependencies with `-Ylog-classpath`.
[error] A full rebuild may help if 'JUnitRunner.class' was compiled against an incompatible version of org.
[error]   implicit class TestingFunctionsOnCircuit(val circuit: Circuit) extends AnyVal {
[error]                  ^
[warn] one warning found
[error] one error found
[error] (Test / compileIncremental) Compilation failed

when compiling for 2.11.12. Adding a specific dependency on junit in build.sbt seems to alleviate the issue.

NOTE: mill has a similar problem, so it may be a ammonite issue.

@jackkoenig
Copy link
Contributor

Would you mind adding a short explanation as a comment in the build.sbt?

@ucbjrl ucbjrl merged commit 75360af into master Nov 21, 2018
@ucbjrl ucbjrl deleted the bumpsbt branch November 21, 2018 18:19
@ucbjrl ucbjrl added this to the 3.1.4 milestone Dec 4, 2018
@ucbjrl ucbjrl modified the milestones: 3.1.4, 3.2.0 Dec 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants