Aggregate coverage - aggregate tests but not publishing #974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Discover a working combination of aggregate usage to enable coverage of subprojects testing but publish a single Jar. This should finally fix #772.
ducky64
previously approved these changes
Jan 5, 2019
There was a problem hiding this comment.
Not sure what I'm looking at but if tests pass and dependencies build against it then it's probably fine?
Maybe add a comment in there somewhere explaining this since it's not immediately obvious from the code what's going on? I'm assuming this is another way of not publishing coreMacros and chiselFrontend as individual JARs that has less side effects?
Remove vestiges of earlier (failing) attempts to provide aggregation for everything but publishing JARs.
Use "scalastyle-test-config.xml" for scalastyle config in tests. Enable "_" in method names and accept method names ending in "_=". Re-sync scalastyle-test-config.xml with scalastyle-config.xml
ucbjrl
dismissed stale reviews from ducky64 and chick
Source changes require re-review
|
Consensus: move scalastyle changes to new PR |
ucbjrl
added a commit
that referenced
this pull request
Mar 18, 2019
* Update style warnings now that subprojects are aggregated. Use "scalastyle-test-config.xml" for scalastyle config in tests. Enable "_" in method names and accept method names ending in "_=". Re-sync scalastyle-test-config.xml with scalastyle-config.xml * Remove bogus tests that crept in with git add * Add missing import.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #772
Type of change: bug report
Impact: no functional change
Development Phase: implementation
Release Notes
Discover a working combination of aggregate usage to enable coverage of subprojects testing but publish a single Jar.
This should finally fix #772.