[Minor] Allow direct construction of aggregates #48
+34
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows expression of aggregate literals. Aggregate construction is an expression, so it is not usable on the lhs of a connect.
|
Is it necessary for types to be passive types? |
|
I don't think it is necessary to have passive types. An aggregate construction should work like a wire with all fields connected. Obviously for a literal aggregate, you would need a passive type for flow to work (a constant can't be a sink). |
darthscsi
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows expression of aggregate literals. Aggregate construction is an expression, so it is not usable on the lhs of a connect.