[patch] Tweak read grammar to allow read(probe(x)) as in examples. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably doesn't need to be draft, seems harmless (and a good improvement re:making spec examples legal)! but not eager to rush 👍 . |
seldridge
approved these changes
Apr 8, 2023
This isn't really generally useful but might as well allow it as it's useful for examples (such as those in spec already!). Note you still can't `read(probe(x).y)` but not worth allowing when you might as well `read(probe(x.y))`.
dtzSiFive
force-pushed
the
feature/read-refexpr
branch
from
cfba55f to
6ec64af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't really generally useful but might as well allow it as it's useful for examples (such as those in spec already!).
Note you still can't
read(probe(x).y)but not worth allowing when you might as wellread(probe(x.y)).