This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Allow casts in AsyncReset literal value check #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chisel emits all literals as UInts cast to the correct type, make CheckResets support casts when checking that async reset registers are reset to literal values.
seldridge
approved these changes
Apr 14, 2020
seldridge
reviewed
Apr 14, 2020
| case Some(other) => findDriver(drivers)(other) | ||
| case None => expr | ||
| } | ||
| @tailrec |
seldridge
added
bugfix
Please Merge
mergify bot
pushed a commit
that referenced
this pull request
Apr 14, 2020
Chisel emits all literals as UInts cast to the correct type, make CheckResets support casts when checking that async reset registers are reset to literal values. Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> (cherry picked from commit f8546a7)
mergify
bot
added
the
Backported
mergify bot
added a commit
that referenced
this pull request
Apr 14, 2020
* Allow casts in AsyncReset literal value check (#1523) Chisel emits all literals as UInts cast to the correct type, make CheckResets support casts when checking that async reset registers are reset to literal values. Co-authored-by: Schuyler Eldridge <schuyler.eldridge@ibm.com> (cherry picked from commit f8546a7) * Remove intervals test Co-authored-by: Jack Koenig <koenig@sifive.com>
|
#1045 |
|
😜 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chisel emits all literals as UInts cast to the correct type, make
CheckResets support casts when checking that async reset registers are
reset to literal values.
mea culpa, mea culpa, mea maxima culpa 😞
I've marked this
1.2.xbecause, well obviously. The autobackport will fail because of intervals but I'll fix it up manually.Contributor Checklist
[ ] Did you update the FIRRTL spec to include every new feature/behavior?Type of Improvement
API Impact
Extends the API for accepted async literal reset values. In particular, this makes it possible to define AsyncReset registers of non-UInt type in Chisel 😶
Backend Code Generation Impact
None
Desired Merge Strategy
Don't care
Release Notes
Support cast literals as async reset values
Reviewer Checklist (only modified by reviewer)
Please Merge?