Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

Deprecate CompilerAnnotation #1870

Merged
merged 7 commits into from
Aug 28, 2020
Merged

Deprecate CompilerAnnotation #1870

merged 7 commits into from
Aug 28, 2020

Commits on Aug 27, 2020

  1. CompilerAnnotation$ emits RunFirrtlTransform 

    Change the CompilerAnnotation object to emit
RunFirrtlTransformAnnotations containing the associated emitter.

This requires a fix in the Driver compatibility layer to know how to
enable one-file-per module emission if either a CompilerAnnotation or
a RunFirrtlTransformAnnotation(_: Emitter) is present.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    2fcb94d View commit details
    Browse the repository at this point in the history

  2. Add ConvertCompilerAnnotation phase 

    Add a phase, ConvertCompilerAnnotation, that converts a
CompilerAnnotation to a RunFirrtlTransformAnnotation. This provides a
warning to the user if this path is taken.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    55f1a7f View commit details
    Browse the repository at this point in the history

  3. Add test of ConvertCompilerAnnotation 

    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 27, 2020
    Configuration menu
    Copy the full SHA
    ecc206a View commit details
    Browse the repository at this point in the history

Commits on Aug 28, 2020

  1. Deprecate CompilerAnnotation$, move helper methods 

    Deprecate the CompilerAnnotation companion object and move it's
private utility inside the RunFirrtlTransformAnnotation companion
object.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    ae8e30e View commit details
    Browse the repository at this point in the history

  2. Make ConvertCompilerAnnotations private[firrtl] 

    Make this phase private to avoid adding a deprecation warning. Also,
remove an unused string value.

Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    ec63017 View commit details
    Browse the repository at this point in the history

  3. Fix incorrect string in test 

    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    348a899 View commit details
    Browse the repository at this point in the history

  4. Add test that '-X verilog', no emitter yields file 

    Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
    @seldridge
    seldridge committed Aug 28, 2020
    Configuration menu
    Copy the full SHA
    2e2a0bd View commit details
    Browse the repository at this point in the history