This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
Bump ANTLR version and change directory to play nice with IntelliJ #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkoenig
added a commit
that referenced
this pull request
Jun 28, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes where the ANTLR plugin emits the generated Java source which plays a little nicer with IntelliJ. With this change the steps I followed are:
clone firrtl(whether inside IntelliJ or not)in the command line:
sbt "antlr4:antlr4Generate"In IntelliJ build and do whatever you want!
I suspect the manual command to the
antlr4Generatetask is required with any changes to the grammar, but those are rare anyway.Also bump ANTLR for good measure