This repository has been archived by the owner on Aug 20, 2024. It is now read-only.
[F764.1] Bump scopt from 3.6.0 -> 3.7.0 #875
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seldridge
force-pushed
the
issue-764-refactor-pr-pointer
branch
from
d7162b5
to
890d9d3
Compare
|
What happens if you use FIRRTL with scopt 3.7.0 in Chisel with scopt 3.6.0? Is this a "bump everyone at the same time" or can we be more decoupled? |
|
Great question. Checking on that... (I may have to wait until tomorrow to give you an answer.) |
|
This causes 3.7.0 to be used by Chisel. See: Shouldn't be any functional problems, but I'll throw a PR at Chisel. |
This was referenced Aug 22, 2018
seldridge
changed the title
seldridge
force-pushed
the
issue-764-refactor-pr-pointer
branch
2 times, most recently
from
6bebf7e
to
f47362e
Compare
seldridge
changed the title
azidar
approved these changes
Aug 29, 2018
This provides support for increased introspection of options inside of scopt, e.g., getting an options short option (shortOpt). Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
seldridge
force-pushed
the
issue-764-refactor-pr-pointer
branch
from
0e5be2a
to
1035821
Compare
ucbjrl
pushed a commit
that referenced
this pull request
Sep 14, 2018
[F764.1] Bump scopt from 3.6.0 -> 3.7.0 Signed-off-by: Schuyler Eldridge <schuyler.eldridge@ibm.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides support for increased introspection of options inside of
scopt, e.g., getting an options short option (shortOpt).
Patch 1 for #764
Signed-off-by: Schuyler Eldridge schuyler.eldridge@ibm.com