Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation to diplomacy.(LazyModule part) #2311

Merged
merged 55 commits into from
Jun 7, 2020
Merged

Documentation to diplomacy.(LazyModule part) #2311

merged 55 commits into from
Jun 7, 2020

Commits on Mar 3, 2020

  1. add documentation to LazyModule.

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    dd6fd6b View commit details
    Browse the repository at this point in the history

  2. finish Nodes diagram as prologue

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    cd59bc5 View commit details
    Browse the repository at this point in the history

  3. wip inline documentations

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5d90576 View commit details
    Browse the repository at this point in the history

  4. more comments on Nodes

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    4d990ac View commit details
    Browse the repository at this point in the history

  5. more docs on resolveStar

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    5dede3f View commit details
    Browse the repository at this point in the history

  6. fix according to review. 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    bd61ef4 View commit details
    Browse the repository at this point in the history

  7. Apply suggestions from rxia's code review. 

    Co-Authored-By: Richard Xia <richardxia@richardxia.com>
    @sequencer @richardxia
    sequencer and richardxia committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    76e67c9 View commit details
    Browse the repository at this point in the history

  8. distinguish names.

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    b08e671 View commit details
    Browse the repository at this point in the history

  9. changes for review

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    2cf43a0 View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-Authored-By: Richard Xia <richardxia@richardxia.com>
Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @richardxia @mwachs5
    3 people committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    39c79fa View commit details
    Browse the repository at this point in the history

  11. comments on valName

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    971cb53 View commit details
    Browse the repository at this point in the history

  12. revoke changes to code.

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    2d8f711 View commit details
    Browse the repository at this point in the history

  13. add todo for <>

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    448b882 View commit details
    Browse the repository at this point in the history

  14. revert Nodes.scala

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    2af7a45 View commit details
    Browse the repository at this point in the history

  15. change requested by review

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    b842720 View commit details
    Browse the repository at this point in the history

  16. polish sourceInfo 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored Mar 3, 2020
    Configuration menu
    Copy the full SHA
    06315d9 View commit details
    Browse the repository at this point in the history

  17. fix Dangle doc

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    d9f0f58 View commit details
    Browse the repository at this point in the history

  18. polish to docs 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored Mar 3, 2020
    Configuration menu
    Copy the full SHA
    60199e8 View commit details
    Browse the repository at this point in the history

  19. move library doc to package

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    f992817 View commit details
    Browse the repository at this point in the history

  20. InModuleBody doc

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    583784b View commit details
    Browse the repository at this point in the history

  21. Merge remote-tracking branch 'sequencer/diplomacy_doc' into diplomacy… 

    …_doc
    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    83c3d64 View commit details
    Browse the repository at this point in the history

  22. mirror fix

    @sequencer
    sequencer committed Mar 3, 2020
    Configuration menu
    Copy the full SHA
    849164c View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored Mar 4, 2020
    Configuration menu
    Copy the full SHA
    cd95ac1 View commit details
    Browse the repository at this point in the history

  2. move package doc to Nodes.

    @sequencer
    sequencer committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    2d10b74 View commit details
    Browse the repository at this point in the history

  3. doc for LazyRawModuleImp

    @sequencer
    sequencer committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    702ee54 View commit details
    Browse the repository at this point in the history

  4. Update scaladoc for LazyModule

    @mwachs5
    mwachs5 authored Mar 4, 2020
    Configuration menu
    Copy the full SHA
    626b82a View commit details
    Browse the repository at this point in the history

  5. Apply suggestions from code review 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored Mar 4, 2020
    Configuration menu
    Copy the full SHA
    6ce98ea View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Update src/main/scala/diplomacy/LazyModule.scala

    @mwachs5
    mwachs5 authored Mar 6, 2020
    Configuration menu
    Copy the full SHA
    7b07c9e View commit details
    Browse the repository at this point in the history

  2. Update src/main/scala/diplomacy/LazyModule.scala

    @mwachs5
    mwachs5 authored Mar 6, 2020
    Configuration menu
    Copy the full SHA
    47a881e View commit details
    Browse the repository at this point in the history

  3. Apply suggestions from code review

    @mwachs5
    mwachs5 authored Mar 6, 2020
    Configuration menu
    Copy the full SHA
    3607798 View commit details
    Browse the repository at this point in the history

  4. LazyModule documentation: add some placeholders

    @mwachs5
    mwachs5 authored Mar 6, 2020
    Configuration menu
    Copy the full SHA
    490d362 View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored Mar 7, 2020
    Configuration menu
    Copy the full SHA
    967a685 View commit details
    Browse the repository at this point in the history

Commits on Mar 12, 2020

  1. bug fixes for comments.

    @sequencer
    sequencer committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    bbc3438 View commit details
    Browse the repository at this point in the history

  2. Fix up scaladoc style. 

    Specifically ensure there is a blank line between the summary sentence
and extra description, as well as ending block comments with a single
`*/` rather than a `* */`.
    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    edcd6c6 View commit details
    Browse the repository at this point in the history

  3. Fix rendering of lists in scaladoc.

    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    f60c845 View commit details
    Browse the repository at this point in the history

  4. Add missing blank line.

    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    b36c7ce View commit details
    Browse the repository at this point in the history

  5. Properly capitalize GraphML, a proper noun.

    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    ae638c2 View commit details
    Browse the repository at this point in the history

  6. Move InModuleBody.apply doc to top of companion object.

    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    6a3309e View commit details
    Browse the repository at this point in the history

  7. Update src/main/scala/diplomacy/LazyModule.scala

    @mwachs5
    mwachs5 authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    c8a9ea7 View commit details
    Browse the repository at this point in the history

  8. Replace imperative scaladocs with descriptive ones for vals.

    @richardxia
    richardxia authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    47f2046 View commit details
    Browse the repository at this point in the history

  9. Update LazyModule.scala

    @mwachs5
    mwachs5 authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    54859fe View commit details
    Browse the repository at this point in the history

  10. Remove excessive spacing before cross references.

    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    9621c7e View commit details
    Browse the repository at this point in the history

  11. Miscellaneous copy changes.

    @richardxia
    richardxia committed Mar 12, 2020
    Configuration menu
    Copy the full SHA
    674abd5 View commit details
    Browse the repository at this point in the history

  12. Merge pull request #1 from richardxia/rxia-diplomacy_doc 

    Diplomacy docs updates
    @sequencer
    sequencer authored Mar 12, 2020
    Configuration menu
    Copy the full SHA
    c4d7416 View commit details
    Browse the repository at this point in the history

Commits on Mar 13, 2020

  1. Apply suggestions from code review 

    Co-Authored-By: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored Mar 13, 2020
    Configuration menu
    Copy the full SHA
    0841bfc View commit details
    Browse the repository at this point in the history

Commits on May 6, 2020

  1. Merge branch 'master' into diplomacy_doc

    @sequencer
    sequencer committed May 6, 2020
    Configuration menu
    Copy the full SHA
    21a0b90 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2020

  1. Merge branch 'master' into diplomacy_doc

    @sequencer
    sequencer committed May 7, 2020
    Configuration menu
    Copy the full SHA
    799398a View commit details
    Browse the repository at this point in the history

Commits on May 22, 2020

  1. Merge remote-tracking branch 'origin/master' into diplomacy_doc

    @sequencer
    sequencer committed May 22, 2020
    Configuration menu
    Copy the full SHA
    5143931 View commit details
    Browse the repository at this point in the history

  2. mirror change

    @sequencer
    sequencer committed May 22, 2020
    Configuration menu
    Copy the full SHA
    4713e5b View commit details
    Browse the repository at this point in the history

  3. reformat, add some type defines, small code change for better underst… 

    …anding.
    @sequencer
    sequencer committed May 22, 2020
    Configuration menu
    Copy the full SHA
    5ddd8eb View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review

    @mwachs5
    mwachs5 authored May 22, 2020
    Configuration menu
    Copy the full SHA
    e5c22b2 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2020

  1. Update src/main/scala/diplomacy/LazyModule.scala

    @mwachs5
    mwachs5 authored May 23, 2020
    Configuration menu
    Copy the full SHA
    0a036e4 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review

    @mwachs5
    mwachs5 authored May 23, 2020
    Configuration menu
    Copy the full SHA
    1f2ba0c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2020

  1. update for review

    @sequencer
    sequencer committed May 25, 2020
    Configuration menu
    Copy the full SHA
    caff665 View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Megan Wachs <megan@sifive.com>
    @sequencer @mwachs5
    sequencer and mwachs5 authored May 25, 2020
    Configuration menu
    Copy the full SHA
    3a273a9 View commit details
    Browse the repository at this point in the history