SuperscalarEventSets check width #2506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leikou01
reviewed
Jun 7, 2020
| (counter(log2Ceil(eventSets.size)-1, 0), counter >> eventSetIdBits) | ||
| require(eventSets.size <= (1 << maxEventSetIdBits)) | ||
| require(eventSetIdBits > 0) | ||
| (counter(eventSetIdBits-1, 0), counter >> maxEventSetIdBits) |
There was a problem hiding this comment.
on the high level, what is the purpose of this change?
differentiate the actually eventSet and maxEventSet? and maxEventSet will be limited by the architecture?
There was a problem hiding this comment.
just making the code the same for both EventSet and SuperscalarEventSet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: add the
requirefrom #2125 onto #2337Type of change: other enhancement
Impact: no functional change
Development Phase: implementation
Release Notes
require that
SuperscalarEventSetsevents fit within mask, same as regularEventSets