Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wake: publish location of the ivydependencies.json #2540

Merged
merged 3 commits into from
Jun 26, 2020
Merged

wake: publish location of the ivydependencies.json #2540

merged 3 commits into from
Jun 26, 2020

Conversation

mmjconolly
Copy link
Contributor

@mmjconolly mmjconolly commented Jun 26, 2020 •
edited
Loading

Publish the directory location of the ivydependencies.json for the api-scala wake rules to consume

Note:

  • adds direct wit dependency on api-scala-sifive, as we now use the ivyDepLocations topic
  • api-scala-sifive requires use of wake 0.17.2, so update the rocket-chip CI to reflect this

Related issue:

Type of change: other enhancement

Impact: API addition (no impact on existing code)

Development Phase: implementation

Release Notes

@mmjconolly
Copy link
Contributor Author

cc @rxia @jackkoenig as I can't add reviewers myself

@mmjconolly mmjconolly changed the title Publish the location of the ivpdependencies.json wake: publish location of the ivpdependencies.json Jun 26, 2020
@mmjconolly mmjconolly changed the title wake: publish location of the ivpdependencies.json wake: publish location of the ivydependencies.json Jun 26, 2020
richardxia
richardxia approved these changes Jun 26, 2020
View reviewed changes
Copy link
Member

@richardxia richardxia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@richardxia richardxia merged commit 674f8ca into chipsalliance:master Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardxia richardxia richardxia approved these changes

@jackkoenig jackkoenig Awaiting requested review from jackkoenig

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmjconolly @richardxia