NMI implementation #2711
Merged
NMI implementation #2711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernie-sifive
requested review from
hcook,
aswaterman,
solomatnikov and
mwachs5
mwachs5
reviewed
Nov 7, 2020
mwachs5
reviewed
Nov 7, 2020
hcook
approved these changes
Nov 9, 2020
hcook
reviewed
Nov 11, 2020
| */ | ||
| trait HasTileNMISources extends InstantiatesTiles { this: BaseSubsystem => | ||
| /** NMI input bundle */ | ||
| /** Source of Non-maskable Interrupt (NMI) input bundle to each tile. */ | ||
| val tileNMINode = BundleBridgeEphemeralNode[NMI]() | ||
| val tileNMIIONodes: Seq[BundleBridgeSource[NMI]] = { | ||
| Seq.fill(tiles.size) { |
There was a problem hiding this comment.
I think we need to make some kind of NexusSourceNode that accepts any number of left-hand-side connections so that you don't need this reference to tiles.size here. The miepNode above is playing a similar trick. Anyways, fine as-is and I will look at handling all three of these similarly in a future PR.
| reg_mnstatus.mpp := trimPrivilege(reg_mstatus.prv) | ||
| new_prv := PRV.M | ||
| } | ||
| }.elsewhen (delegate && nmie) { |
There was a problem hiding this comment.
The draft RNMI spec says that exceptions that occur while an NMI handler is active are handled in M-mode and affect mepc, mcause, etc. So they are never delegated. The next case of this when/else is taken in that case.
aswaterman
approved these changes
Nov 12, 2020
There was a problem hiding this comment.
Thanks, @ernie-sifive - I reviewed only the RocketCore/CSRFile changes, but they LGTM.
ZenithalHourlyRate
added a commit
to OpenRigil/rocket-chip
that referenced
this pull request
Apr 2, 2022
Rocket already implemented NMI in chipsalliance#2711, however, riscv-opcodes currently does not have NMI as it is a WIP (See riscv/riscv-opcodes#67) To avoid generating Instructions.scala from a patched riscv-opcodes, putting NMI related insts/CSRs into CustomInstructions is reasonable.
ZenithalHourlyRate
added a commit
to OpenRigil/rocket-chip
that referenced
this pull request
Apr 17, 2022
Rocket already implemented NMI in chipsalliance#2711, however, riscv-opcodes currently does not have NMI as it is a WIP (See riscv/riscv-opcodes#67) To avoid generating Instructions.scala from a patched riscv-opcodes, putting NMI related insts/CSRs into CustomInstructions is reasonable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
Type of change: feature request
Impact: API addition (no impact on existing code)
Development Phase: implementation
Release Notes