Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorg files to have a toplevel verible/ directory #2292

Merged
merged 4 commits into from
Nov 23, 2024

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Nov 23, 2024

add a toplevel verible/ path, so that common/ and verilog/ don't start at the toplevel. So make them verible/common/ and verible/verilog/

Also, while touching anyway all files

  • Uniformly clang-format all of them
  • Use the same naming convention of files: always use dashes to separate filenames and highlight test files by having them with _test. So typical file set would be foo-bar.h, foo-bar.cc and foo-bar_test.cc

Currently, we're fetching them from head, which makes the smoke test
run flaky as these projects change over time.
Pointers and references should be aligned as C intends it to be.
@hzeller hzeller changed the title Reorg files a bit Reorg files to have a toplevel verible/ directory Nov 23, 2024
Dashes separate filename elements, while corresponding
tests are separated from the rest with _test.cc

Since file is renamed, use `git log --follow` to get
more history.
@hzeller hzeller force-pushed the feature-20241122-update-paths branch 3 times, most recently from 247a264 to c255bb7 Compare November 23, 2024 07:46
Everything toplevel common/ and verilog/ is now
named verible/common/ and verible/verilog.

This make it easier to distinguish project-specific
files.

Since file is renamed, use `git log --follow` to get
more history.
@hzeller hzeller force-pushed the feature-20241122-update-paths branch from c255bb7 to 877f60d Compare November 23, 2024 09:45
@hzeller hzeller marked this pull request as ready for review November 23, 2024 19:28
@hzeller hzeller merged commit 7850f77 into chipsalliance:master Nov 23, 2024
8 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant