Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MacOS platform compatibility check CI #757

Merged
merged 2 commits into from
Apr 14, 2021
Merged

Add MacOS platform compatibility check CI #757

merged 2 commits into from
Apr 14, 2021

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Apr 14, 2021

Issues: #260

Signed-off-by: Henner Zeller h.zeller@acm.org

Issues: #260

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@googlebot googlebot added the cla: yes All contributors in pull request have signed the CLA with Google. label Apr 14, 2021
Copy link
Collaborator

@mithro mithro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Woot!

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller requested a review from mithro April 14, 2021 17:00
@hzeller
Copy link
Collaborator Author

hzeller commented Apr 14, 2021

Aaaand: it passes :)
(had to revert to older version of ABSL, there is something I probably have to file separately with the absl team)

Copy link
Collaborator

@fangism fangism left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic work!


jobs:
MacOsBuild:
runs-on: macos-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment on what version OS this happens to be? other known versions of OS X Developer Tools?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Version is unknown. Whatever github choses to be 'latest'.
Given that this is just meant as a litmus test, we actually don't really want to know, we just want to make sure that whatever typical latest macos there is, it will compile.

@hzeller hzeller merged commit 47fbcbb into chipsalliance:master Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All contributors in pull request have signed the CLA with Google.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants