Add unit-test for UpwardFileSearch(). #783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
We can't access the test logfiles on the CI machine, so it is important that it prints it out for us to see. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Don't create test structure in toplevel testing::TempDir(), but create our test-specific path. Signed-off-by: Henner Zeller <h.zeller@acm.org>
We can not assume that the full absolute path is the same for the UpwardFileSearch() as it does realpath(). We only know that 'our' part of the filesystem construction will match. Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
tgorochowik
approved these changes
Apr 22, 2021
tgorochowik
reviewed
Apr 22, 2021
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Precondition to change the implementation to use
std::filesystem.
Issues: #765 #307
Signed-off-by: Henner Zeller h.zeller@acm.org