Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expanding Windows tests running in CI #799

Merged
merged 6 commits into from
Apr 28, 2021
Merged

Expanding Windows tests running in CI #799

merged 6 commits into from
Apr 28, 2021

Conversation

hzeller
Copy link
Collaborator

@hzeller hzeller commented Apr 27, 2021

First step: run all to see which pass.

@google-cla google-cla bot added the cla: yes All contributors in pull request have signed the CLA with Google. label Apr 27, 2021
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
Those files don't work on Windows.

Issues #307

Signed-off-by: Henner Zeller <h.zeller@acm.org>
Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller
Copy link
Collaborator Author

hzeller commented Apr 28, 2021

FYI @corco

@corco
Copy link
Collaborator

corco commented Apr 28, 2021

Cool! I hit the wall of linter, but it's nice to see that everything else passes.

The problem with the linter is that bazel rules marked test = true (like the one generated in the linter) needs to create an executable. The rule wright now creates a bash script, which is not executable on Windows.

I started working on a fix, which mostly replaces the current rule with sh_test_with_runfiles_lib

Issues #307

Signed-off-by: Henner Zeller <h.zeller@acm.org>
@hzeller hzeller marked this pull request as ready for review April 28, 2021 04:03
@hzeller hzeller merged commit 8bd35d9 into chipsalliance:master Apr 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes All contributors in pull request have signed the CLA with Google.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants