Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #137 (failure to start LSP client on neovim 0.10+) #138

Open
wants to merge 2 commits into
base: v0.3
Choose a base branch
from

Conversation

RCX777
Copy link

@RCX777 RCX777 commented Jul 7, 2024

Creates a cmd_args table from splitting the cmd string, and passes that to the config instead. This fixes the LSP functionality of distant.nvim for this neovim version.

TODO: for backwards compatibility, I suggest supporting both APIs.

chipsenkbeil and others added 2 commits July 7, 2024 14:03
Creates a `cmd_args` table from splitting the `cmd` string, and passes that to the `config` instead. This fixes the LSP functionality of `distant.nvim` for this neovim version.  

TODO: for backwards compatibility, I suggest supporting both APIs
@chipsenkbeil
Copy link
Owner

Thanks! We should switch to using self:wrap with lsp set to a list instead of a single string. This should result in the return value being an argument list instead of a single string, which should ideally fix the issue without us needing to split by whitespace.

I'll give this a look later.

@jellis206
Copy link

Any progress on this?

@chipsenkbeil
Copy link
Owner

Any progress on this?

It needs to be changed to use wrap() and also to work on both 0.9 and 0.10. I haven't gotten around to working on this yet, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants