Add replacements for TokenApprovalRef #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14.
This regex thingy doesn't look the cleanest though, but I don't think we will ever need to touch the
TokenApprovalRef.The regex is also general enough to allow for one line of comment above the struct.
I'd prefer fixing it in this repo than the main repo. Cuz the other way about it is to create a whole new .sol file with a werid name just for this one struct.
May want to do a tiny version bump from 4.2.0 -> 4.2.1 for the Upgradeable repo.
@jovijovi can you help confirm that this will fix the issue?