-
Notifications
You must be signed in to change notification settings - Fork 842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Diamond Storage #267
Comments
This is true, and one of my biggest complaints about most of the 721 implementations, they cannot be used with a diamond if they use the common storage approach. Even OZ's upgradeable suite does this. :( Why would anyone want to build their contract so it would be diamond compatible if it isn't intended specifically to be used that way? As what we do with Web3 evolves, upgradeability and larger contracts will be the norm, and currently diamond is the only upgradeable proxy standard that supports near infinite expansion of contract size. |
Yes, OpenZeppelin plans to adopt diamond storage, but we don't know when that will be:
|
It would be useful if the ERC721A implementation was changed to use diamond storage.
Diamond storage is a contract storage technique that makes organizing and upgrading data in proxy contracts and diamonds possible.
If the ERC721A implementation used diamond storage then it could be used in diamonds and other proxy contracts without change.
The text was updated successfully, but these errors were encountered: