-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contract to use diamond storage #9
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
approved these changes
May 21, 2022
Can you please update the README / docs. Took me some time to find this :) (Current one fails with |
Remove the ",":
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a breaking change.
scripts/replace-imports.js
.scripts/transpile-merge.sh
to use@gnus.ai/upgrade-safe-transpiler-diamond
.package.json
to use@gnus.ai/upgrade-safe-transpiler-diamond
.package.json
.Due to the high likelihood of namespace collision when someone uses OpenZeppelin Upgradeable repo with this PR, the following re-namings are automatically done:
contracts/Initializable.sol
->contracts/ERC721A__Initializable.sol
contracts/InitializableStorage.sol
->contracts/ERC721A__InitializableStorage.sol
modifer initializer
->modifier initializerERC721A
modifer onlyInitializing
->modifier onlyInitializingERC721A
When inheriting from
ERC721AUpgradeable
and a OpenZeppelin Upgradeable contract, the initializer must have both theinitializerERC721A
andinitializer
modifiers.Issue: chiru-labs/ERC721A#267