Rename _msgSender #280
Merged
Rename _msgSender #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vectorized
referenced
this pull request
May 14, 2022
* Remove OpenZeppelin * Add tests * Add suggested changes
|
On the same note, I'm also thinking of renaming |
|
I merge this first in case people are using forge to install (which doesn't pull from npm, but rather github). Most people will use Ownable but not GSN, so this PR is quite urgent for developer Quality of Life. Meanwhile, there is a poll on the name at https://twitter.com/optimizoor/status/1525402330900086784 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_msgSender()is used for writing GSN compatible contracts.When users import OZ and inherit from their contracts (e.g. Ownable), our
_msgSender()will conflict with their definition.I suggest to keep an overrideable function, with a different name, such that it won't conflict.
So now, when writing GSN compatible contracts with OZ, one just have to override new function to return
_msgSender().