Remove ERC721Enumerable interface #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coindegen
reviewed
Jan 28, 2022
| @@ -6,7 +6,6 @@ pragma solidity ^0.8.0; | |||
| import "@openzeppelin/contracts/token/ERC721/IERC721.sol"; | |||
| import "@openzeppelin/contracts/token/ERC721/IERC721Receiver.sol"; | |||
| import "@openzeppelin/contracts/token/ERC721/extensions/IERC721Metadata.sol"; | |||
| import "@openzeppelin/contracts/token/ERC721/extensions/IERC721Enumerable.sol"; | |||
| import "@openzeppelin/contracts/utils/Address.sol"; | |||
| import "@openzeppelin/contracts/utils/Context.sol"; | |||
| import "@openzeppelin/contracts/utils/Strings.sol"; | |||
There was a problem hiding this comment.
in the comment on line 16 you can delete the "Enumerable" part of "including the Metadata and Enumerable extension".
|
@willisk bumping above comment- otherwise we can work off this branch to add ERC721AEnumerable |
|
@chiru-labs please see #81 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes ERC721Enumerable interface. The functionality introduced by the interface has its use in ERC721Enumerable.sol, however here it does not add any value.
In addition, the function
tokenOfOwnerByIndex(address owner, uint256 index)should never be called on-chain. To remove any possibility of an accidental call on-chain, I propose to remove the interface (except for totalSupply()).See #18