Add function to directly set extra data #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cygaar
reviewed
Jun 14, 2022
| /** | ||
| * @dev Directly sets the extra data for the ownership data `index`. | ||
| */ | ||
| function _setExtraDataAt(uint256 index, uint24 extraData) internal { |
There was a problem hiding this comment.
Not necessarily specific to this PR, but we use index and tokenId to access _packedOwnerships. We should probably make these consistent in a a future PR.
There was a problem hiding this comment.
index refers to something that may not be initialized, and will expose the user to the underlying logic.
tokenId refers to something that is initialized.
| assembly { | ||
| extraDataCasted := extraData | ||
| } | ||
| packed = (packed & BITMASK_EXTRA_DATA_COMPLEMENT) | (extraDataCasted << BITPOS_EXTRA_DATA); |
There was a problem hiding this comment.
Just curious, is this cheaper to do in assembly?
There was a problem hiding this comment.
Nope. That's why I removed it.
cygaar
approved these changes
Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case people want to use the extra data to store the type of token.
Changes:
_setAuxfunction body to be consistent with the function body of_setExtraDataAt._nextExtraDataprivate. Forgot to make it private previously.previousExtraDatatoextraData.Cuz there is another variable called
prevPackedOwnership, and this triggers OCD.